Use Type_Dontcare for _ expressions in table entries #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Budiu <[email protected]>
|
I would hold off merging this until we resolve p4lang/p4-spec#1120. |
|
This is a bug, _ should unify with everything. |
|
Agree. This was a bug and is independent of the earlier issue about keys.
…On Wed, Jul 20, 2022 at 6:02 PM Mihai Budiu ***@***.***> wrote:
This is a bug, _ should unify with everything.
The solution should be different if you want such tables to be empty.
—
Reply to this email directly, view it on GitHub
<#3444 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOCFUQFRMP3MWRFSJJY6A3VVBZPDANCNFSM53XAYLOA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
No problem -- but then get ready to deal with the fallout :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihai Budiu [email protected]
Fixes #3442
For this to work we need to remember whether the original expression was _ or { _ }.
That's why the IR class had to be augmented.
(We may need to do the same for select expressions, which suffer from a similar confusion.)